linux-kernel - Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496997489.22624.63.camel@linux.intel.com>
Date:   Fri, 09 Jun 2017 11:38:09 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Peter Rosin <peda@...ntia.se>,
        Luis Oliveira <Luis.Oliveira@...opsys.com>, wsa@...-dreams.de,
        robh+dt@...nel.org, mark.rutland@....com,
        jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style
 fixes.

On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote:
> On 2017-06-08 19:36, Luis Oliveira wrote:
> > complicated to review. The work here won't bring any additional work
> > to
> > backported fixes because is just style and reordering.
> 
> I challenge that. If there is an old bug that existed before this
> patch
> that is fixed in the future after this patch has been applied, it
> might
> very well be hard_er_ to backport that fix to a point before this
> patch
> has been applied. So, what do you mean?

I asked this during review of ~v3. I don't remember what Wolfram told
about it.

> 
> > @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
> >  	}
> >  
> >  	i2c_dw_disable_int(dev);
> > -	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
> > irq_flags,
> > +	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr,
> > irq_flags,
> >  			     dev_name(dev->dev), dev);
> 

> Two extra spaces needed to align with the opening bracket.

It's a bikeshedding, though it looks like v11 is needed anyway (see
kbuild bot complains), thus it might be addressed as well.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy