linux-kernel - Re: [PATCH] phy: cpcap-usb: add MUSB dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ebc90ce-3b0e-528b-3138-127a802637ea@ti.com>
Date:   Fri, 9 Jun 2017 17:30:56 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Arnd Bergmann <arnd@...db.de>
CC:     Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency



On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
>> When MUSB is a loadable module, we get a link error for a built-in
>> CPCAP driver:
>>
>> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
>> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
>>
>> This adds a Kconfig dependency to prevent this broken configuration,
>> enforcing that CPCAP can only be a module when MUSB is also a module.
>>
>> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

merged, thanks!

-Kishon
> 
> -- Sebastian
> 
>> ---
>>  drivers/phy/motorola/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
>> index 91a46cffd639..6bb7d6bdf1bf 100644
>> --- a/drivers/phy/motorola/Kconfig
>> +++ b/drivers/phy/motorola/Kconfig
>> @@ -4,6 +4,7 @@
>>  config PHY_CPCAP_USB
>>  	tristate "CPCAP PMIC USB PHY driver"
>>  	depends on USB_SUPPORT && IIO
>> +	depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
>>  	select GENERIC_PHY
>>  	select USB_PHY
>>  	help
>> -- 
>> 2.9.0
>>