linux-kernel - Re: [PATCH] phy: cpcap-usb: add MUSB dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170612080916.GV3730@atomide.com>
Date:   Mon, 12 Jun 2017 01:09:16 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency

* Kishon Vijay Abraham I <kishon@...com> [170609 05:04]:
> 
> 
> On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> >> When MUSB is a loadable module, we get a link error for a built-in
> >> CPCAP driver:
> >>
> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
> >>
> >> This adds a Kconfig dependency to prevent this broken configuration,
> >> enforcing that CPCAP can only be a module when MUSB is also a module.
> >>
> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> 
> merged, thanks!

Yup thanks for fixing it.

Regards,

Tony