linux-kernel - [PATCH] drivers: block: correct brackets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20170609120707.323-1-kirkseraph@gmail.com>
Date:   Fri,  9 Jun 2017 14:07:06 +0200
From:   Seraphime Kirkovski <kirkseraph@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     sfr@...b.auug.org.au, Seraphime Kirkovski <kirkseraph@...il.com>,
        Jens Axboe <axboe@...com>, Ming Lei <tom.leiming@...il.com>,
        Hannes Reinecke <hare@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Omar Sandoval <osandov@...com>
Subject: [PATCH] drivers: block: correct brackets

GCC complained on linux-next about

drivers/block/loop.c:1149:3: warning: this ‘if’ clause does not guard...
[-Wmisleading-indentation]
   if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
   ^~
drivers/block/loop.c:1152:4: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the ‘if’
    goto exit;

This adjustes the brackets to the inner if.

Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Signed-off-by: Seraphime Kirkovski <kirkseraph@...il.com>
---
 The patch was made against linux-next.

 drivers/block/loop.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4d376c10a97a..e288fb30100f 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1147,10 +1147,11 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	    ((lo->lo_flags & LO_FLAGS_BLOCKSIZE) &&
 	     lo->lo_logical_blocksize != LO_INFO_BLOCKSIZE(info))) {
 		if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
-				     LO_INFO_BLOCKSIZE(info)))
+				     LO_INFO_BLOCKSIZE(info))) {
 			err = -EFBIG;
 			goto exit;
 		}
+	}
 
 	loop_config_discard(lo);
 
-- 
2.11.0