linux-kernel - RE: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose embedded WMI MOF metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67cc75c9e0ef4a21a168ab3b4dd1e727@ausx13mpc124.AMER.DELL.COM>
Date:   Fri, 9 Jun 2017 15:46:12 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>
CC:     <luto@...capital.net>, <dvhart@...radead.org>,
        <platform-driver-x86@...r.kernel.org>,
        <andriy.shevchenko@...ux.intel.com>, <luto@...nel.org>,
        <rjw@...ysocki.net>, <linux-kernel@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose
 embedded WMI MOF metadata

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@...il.com]
> Sent: Wednesday, June 7, 2017 3:50 PM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: luto@...capital.net; dvhart@...radead.org; platform-driver-
> x86@...r.kernel.org; andriy.shevchenko@...ux.intel.com; luto@...nel.org;
> rjw@...ysocki.net; linux-kernel@...r.kernel.org; linux-acpi@...r.kernel.org
> Subject: Re: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose
> embedded WMI MOF metadata
> 
> On Wednesday 07 June 2017 22:23:08 Mario.Limonciello@...l.com wrote:
> > > -----Original Message-----
> > > From: Pali Rohár [mailto:pali.rohar@...il.com]
> > > Sent: Wednesday, June 7, 2017 12:39 PM
> > > To: Limonciello, Mario <Mario_Limonciello@...l.com>
> > > Cc: luto@...capital.net; dvhart@...radead.org; platform-driver-
> > > x86@...r.kernel.org; andriy.shevchenko@...ux.intel.com;
> > > luto@...nel.org; rjw@...ysocki.net; linux-kernel@...r.kernel.org;
> > > linux-acpi@...r.kernel.org Subject: Re: [PATCH 15/16]
> > > platform/x86: wmi-mof: New driver to expose embedded WMI MOF
> > > metadata
> > >
> > > On Tuesday 06 June 2017 15:56:21 Pali Rohár wrote:
> > > > On Tuesday 06 June 2017 13:46:16 Mario.Limonciello@...l.com wrote:
> > > > > 2) On my system when you expand the arguments for "void DoBFn"
> > > > > the source doesn't describe individual arguments like you do.
> > > > > Again this might not matter to MOF parsing tools but wanted to
> > > > > let you know in case it does.
> > > >
> > > > I know, this part is missing. Order of arguments are only in ID
> > > > qualifier and not sorted + in/out de-duplicated.
> > >
> > > Implemented! Now arguments are correctly placed based on ID
> > > qualifier.
> >
> > I think it's still off a little though.
> >
> > What I'm getting back now from bmf2mof is:
> > 	void DoBFn([in, Description("Fn buf"), out] BDat Data);
> >
> > Whereas source puts Description as the last argument:
> > 	void DoBFn([in, out, Description("Fn buf")] BDat Data);
> 
> In BMOF from my Latitude E6440 there are specified two parameters with
> index 0. One with qualifiers ("in", Description("Fn buf")) and one with
> ("out", Description("Fn buf")). I think you have similar/same data in
> BMOF.
> 
> In my bmf2mof I just combined those two parameters into one (when name,
> type and index matches) and concatenate also qualifiers with removing
> duplicates.
> 
> Do not know what is correct way, but I think qualifiers are just
> unordered set. MS decompiler probably put "in" and "out" qualifiers
> before any other for better readability.

Have you tried to run it through mofcomp.exe and then decompile again
with bmf2mof?  As long as it's coming out the same you're probably right.

> 
> > > > > source:
> > > > > 	void DoBFn([in, out, Description("Fn buf")] BDat Data);
> > > > >
> > > > > bmf2mof:
> > > > > 	void doBFn([in, Description("Fn buf"), ID(0)] BDat Data, [out,
> > > > > 	Description("Fn buf"), ID(0)] BDat Data);
> > >
> > > --
> > > Pali Rohár
> > > pali.rohar@...il.com
> 
> --
> Pali Rohár
> pali.rohar@...il.com