linux-kernel - Re: [PATCH] VFS: Differentiate mount flags (MS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31121.1497024264@warthog.procyon.org.uk>
Date:   Fri, 09 Jun 2017 17:04:24 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jeff Layton <jlayton@...hat.com>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        mszeredi@...hat.com
Subject: Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

Jeff Layton <jlayton@...hat.com> wrote:

> I guess you mean stuff like affs_fill_super which does:
> 
>     sb->s_flags |= MS_NODEV | MS_NOSUID;
> 
> It seems like it's doing that too late to be useful.

Actually, after the change, it seems nothing actually tests SB_NOSUID,
SB_NODEV or SB_NOEXEC, so those bits should probably be removed.

I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed
from the UAPI header.

David