linux-kernel - Re: [PATCH] VFS: Differentiate mount flags (MS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201706110108.06cQbzCU%fengguang.wu@intel.com>
Date:   Sun, 11 Jun 2017 01:15:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     kbuild-all@...org, viro@...iv.linux.org.uk, dhowells@...hat.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        jlayton@...hat.com, mszeredi@...hat.com
Subject: Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal
 superblock flags

Hi David,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.12-rc4]
[cannot apply to next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Howells/VFS-Differentiate-mount-flags-MS_-from-internal-superblock-flags/20170611-000825
config: i386-randconfig-x073-06041529 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from fs/cifs/connect.c:21:0:
   fs/cifs/connect.c: In function 'compare_mount_options':
>> include/linux/fs.h:1266:20: error: expected ')' before numeric constant
    #define SB_NOEXEC  8 /* Disallow program execution */
                       ^
>> fs/cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
            SB_NOEXEC | SB_NOSUID | SB_NODEV)
            ^~~~~~~~~
>> fs/cifs/connect.c:2883:21: note: in expansion of macro 'CIFS_MS_MASK'
     if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
                        ^~~~~~~~~~~~
>> include/linux/fs.h:1266:20: error: expected ')' before numeric constant
    #define SB_NOEXEC  8 /* Disallow program execution */
                       ^
>> fs/cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
            SB_NOEXEC | SB_NOSUID | SB_NODEV)
            ^~~~~~~~~
   fs/cifs/connect.c:2883:57: note: in expansion of macro 'CIFS_MS_MASK'
     if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
                                                            ^~~~~~~~~~~~

vim +1266 include/linux/fs.h

  1260	 * sb->s_flags.  Note that these mirror the equivalent MS_* flags where
  1261	 * represented in both.
  1262	 */
  1263	#define SB_RDONLY	 1	/* Mount read-only */
  1264	#define SB_NOSUID	 2	/* Ignore suid and sgid bits */
  1265	#define SB_NODEV	 4	/* Disallow access to device special files */
> 1266	#define SB_NOEXEC	 8	/* Disallow program execution */
  1267	#define SB_SYNCHRONOUS	16	/* Writes are synced at once */
  1268	#define SB_MANDLOCK	64	/* Allow mandatory locks on an FS */
  1269	#define SB_DIRSYNC	128	/* Directory modifications are synchronous */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30676 bytes)