linux-kernel - Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170610095649.2731e8fb@canb.auug.org.au>
Date:   Sat, 10 Jun 2017 09:56:49 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for
 bus_type

Hi Greg,

On Tue,  6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>
> -static struct device_attribute serdev_device_attrs[] = {
> -	__ATTR_RO(modalias),
> -	__ATTR_NULL
> +static struct attribute *serdev_device_attrs[] = {
                            ^^^^^^^^^^^^^^^^^^^
Should have been "serdev_device_groups"

> +	&dev_attr_modalias.attr,
> +	NULL,
>  };
> +ATTRIBUTE_GROUPS(serdev_device);
>  
>  static struct bus_type serdev_bus_type = {
>  	.name		= "serial",
> @@ -262,7 +264,7 @@ static struct bus_type serdev_bus_type = {
>  	.probe		= serdev_drv_probe,
>  	.remove		= serdev_drv_remove,
>  	.uevent		= serdev_uevent,
> -	.dev_attrs	= serdev_device_attrs,
> +	.dev_groups	= serdev_device_groups,
>  };
-- 
Cheers,
Stephen Rothwell