linux-kernel - Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170610100122.303cc2dd@canb.auug.org.au>
Date:   Sat, 10 Jun 2017 10:01:22 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for
 bus_type

Hi Greg,

On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> > +static struct attribute *serdev_device_attrs[] = {  
>                             ^^^^^^^^^^^^^^^^^^^
> Should have been "serdev_device_groups"

Sorry, my mistake.

> > +	&dev_attr_modalias.attr,
> > +	NULL,
> >  };
> > +ATTRIBUTE_GROUPS(serdev_device);

I really hate macros that create symbols by concatenating parts. :-(

-- 
Cheers,
Stephen Rothwell