linux-kernel - Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170610115808.GB19554@kroah.com>
Date:   Sat, 10 Jun 2017 13:58:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for
 bus_type

On Sat, Jun 10, 2017 at 10:01:22AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > > +static struct attribute *serdev_device_attrs[] = {  
> >                             ^^^^^^^^^^^^^^^^^^^
> > Should have been "serdev_device_groups"
> 
> Sorry, my mistake.
> 
> > > +	&dev_attr_modalias.attr,
> > > +	NULL,
> > >  };
> > > +ATTRIBUTE_GROUPS(serdev_device);
> 
> I really hate macros that create symbols by concatenating parts. :-(

I totally agree, but it's the only way I could come up with at the time
to make this type of macro to simplify a lot of boiler-plate code.

sorry,

greg k-h