linux-kernel - Re: [PATCH 04/11] kernfs: don't set dentry->d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 14:29:31 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Shaohua Li <shli@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        gregkh@...uxfoundation.org, hch@....de, axboe@...com,
        rostedt@...dmis.org, lizefan@...wei.com, Kernel-team@...com,
        Shaohua Li <shli@...com>
Subject: Re: [PATCH 04/11] kernfs: don't set dentry->d_fsdata

Hello,

On Fri, Jun 02, 2017 at 02:53:57PM -0700, Shaohua Li wrote:
> @@ -570,7 +570,8 @@ static int kernfs_dop_revalidate(struct dentry *dentry, unsigned int flags)
>  		goto out_bad;
>  
>  	/* The kernfs node has been moved? */
> -	if (dentry->d_parent->d_fsdata != kn->parent)
> +	if (d_really_is_negative(dentry->d_parent) ||
> +	    kernfs_dentry_node(dentry->d_parent) != kn->parent)
>  		goto out_bad;

Can we move d_really_is_negative() into kernfs_dentry_node()?  That
might add an additional NULL test to some paths but I don't think that
will ever show up anywhere.

> diff --git a/fs/kernfs/kernfs-internal.h b/fs/kernfs/kernfs-internal.h
> index 3534cfe..82e11fa 100644
> --- a/fs/kernfs/kernfs-internal.h
> +++ b/fs/kernfs/kernfs-internal.h
> @@ -70,6 +70,8 @@ struct kernfs_super_info {
>  };
>  #define kernfs_info(SB) ((struct kernfs_super_info *)(SB->s_fs_info))
>  
> +#define kernfs_dentry_node(d)  ((d_inode(d))->i_private)

I know the prev one is a macro but let's make the new one an inline
function.

Thnaks.

-- 
tejun