linux-kernel - Re: [PATCH v2 2/3] EDAC: altera: simplify calculation of total memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b052bfda-c5a3-7b23-682c-ab59c9c8ad3a@linux.intel.com>
Date:   Mon, 12 Jun 2017 13:34:05 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>, bp@...en8.de,
        linux-edac@...r.kernel.org
Cc:     mchehab@...nel.org, mpe@...erman.id.au,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] EDAC: altera: simplify calculation of total memory

On 06/06/2017 06:54 PM, Chris Packham wrote:
> Use of_address_to_resource() and resource_size() instead of manually
> parsing the "reg" property from the "memory" node(s).
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
> Changes in v2:
> - New
> 
>   drivers/edac/altera_edac.c | 24 ++++++++----------------
>   1 file changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 7717b094fabb..f8b623352627 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -214,24 +214,16 @@ static void altr_sdr_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
>   static unsigned long get_total_mem(void)
>   {
>   	struct device_node *np = NULL;
> -	const unsigned int *reg, *reg_end;
> -	int len, sw, aw;
> -	unsigned long start, size, total_mem = 0;
> +	struct resource res;
> +	int ret;
> +	unsigned long total_mem = 0;
>   
>   	for_each_node_by_type(np, "memory") {
> -		aw = of_n_addr_cells(np);
> -		sw = of_n_size_cells(np);
> -		reg = (const unsigned int *)of_get_property(np, "reg", &len);
> -		reg_end = reg + (len / sizeof(u32));
> -
> -		total_mem = 0;
> -		do {
> -			start = of_read_number(reg, aw);
> -			reg += aw;
> -			size = of_read_number(reg, sw);
> -			reg += sw;
> -			total_mem += size;
> -		} while (reg < reg_end);
> +		ret = of_address_to_resource(np, 0, &res);
> +		if (ret)
> +			continue;
> +
> +		total_mem += resource_size(&res);
>   	}
>   	edac_dbg(0, "total_mem 0x%lx\n", total_mem);
>   	return total_mem;
> 
Nice change! Tested on Cyclone5 DevKit & Arria10 DevKit.

Tested-by: Thor Thayer <thor.thayer@...ux.intel.com>