linux-kernel - Re: [PATCH] audit: style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTaB-yWBjV9j1juLavM7cFo4VL1s-5ow18A1LTieK6gLQ@mail.gmail.com>
Date:   Mon, 12 Jun 2017 18:17:18 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Derek Robson <robsonde@...il.com>
Cc:     Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: style fix

On Sun, Jun 11, 2017 at 10:33 PM, Derek Robson <robsonde@...il.com> wrote:
> Fixed checkpatch.pl warnings of "function definition argument FOO
>  should also have an identifier name"
>
> Signed-off-by: Derek Robson <robsonde@...il.com>
> ---
>  kernel/audit.h | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

I'm going to go ahead and merge this, but I generally dislike
accepting standalone style/formatting patches from people who don't
regularly contribute to the subsystem.  Honestly, I tend to dislike
seeing patches like this from regular contributors as well, I'm just
slightly less annoyed in those cases.

If you are interested in contributing to the audit subsystem, but
aren't sure where to start, I would encourage you to take a look at
some of the outstanding issues on GitHub; patches for any of those
issues would be much more helpful than a style/formatting fix.

* https://github.com/linux-audit/audit-kernel/issues
* https://github.com/linux-audit/audit-testsuite/issues

If you have any questions about those issues, feel free to comment on
the issue, or send an email to the audit mailing list, and we'll do
our best to help you get started.

> diff --git a/kernel/audit.h b/kernel/audit.h
> index ddfce2ea4891..90b891eea204 100644
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -247,13 +247,13 @@ struct audit_netlink_list {
>         struct sk_buff_head q;
>  };
>
> -int audit_send_list(void *);
> +int audit_send_list(void *_dest);
>
>  extern int selinux_audit_rule_update(void);
>
>  extern struct mutex audit_filter_mutex;
> -extern int audit_del_rule(struct audit_entry *);
> -extern void audit_free_rule_rcu(struct rcu_head *);
> +extern int audit_del_rule(struct audit_entry *entry);
> +extern void audit_free_rule_rcu(struct rcu_head *head);
>  extern struct list_head audit_filter_list[];
>
>  extern struct audit_entry *audit_dupe_rule(struct audit_krule *old);
> @@ -301,17 +301,17 @@ extern int audit_exe_compare(struct task_struct *tsk, struct audit_fsnotify_mark
>  #endif /* CONFIG_AUDIT_WATCH */
>
>  #ifdef CONFIG_AUDIT_TREE
> -extern struct audit_chunk *audit_tree_lookup(const struct inode *);
> -extern void audit_put_chunk(struct audit_chunk *);
> -extern bool audit_tree_match(struct audit_chunk *, struct audit_tree *);
> -extern int audit_make_tree(struct audit_krule *, char *, u32);
> -extern int audit_add_tree_rule(struct audit_krule *);
> -extern int audit_remove_tree_rule(struct audit_krule *);
> +extern struct audit_chunk *audit_tree_lookup(const struct inode *inode);
> +extern void audit_put_chunk(struct audit_chunk *chunk);
> +extern bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree);
> +extern int audit_make_tree(struct audit_krule *rule, char *pathname, u32 op);
> +extern int audit_add_tree_rule(struct audit_krule *rule);
> +extern int audit_remove_tree_rule(struct audit_krule *rule);
>  extern void audit_trim_trees(void);
>  extern int audit_tag_tree(char *old, char *new);
> -extern const char *audit_tree_path(struct audit_tree *);
> -extern void audit_put_tree(struct audit_tree *);
> -extern void audit_kill_trees(struct list_head *);
> +extern const char *audit_tree_path(struct audit_tree *tree);
> +extern void audit_put_tree(struct audit_tree *tree);
> +extern void audit_kill_trees(struct list_head *list);
>  #else
>  #define audit_remove_tree_rule(rule) BUG()
>  #define audit_add_tree_rule(rule) -EINVAL
> @@ -323,7 +323,7 @@ extern void audit_kill_trees(struct list_head *);
>  #define audit_kill_trees(list) BUG()
>  #endif
>
> -extern char *audit_unpack_string(void **, size_t *, size_t);
> +extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len);
>
>  extern pid_t audit_sig_pid;
>  extern kuid_t audit_sig_uid;
> @@ -333,7 +333,7 @@ extern int audit_filter(int msgtype, unsigned int listtype);
>
>  #ifdef CONFIG_AUDITSYSCALL
>  extern int audit_signal_info(int sig, struct task_struct *t);
> -extern void audit_filter_inodes(struct task_struct *, struct audit_context *);
> +extern void audit_filter_inodes(struct task_struct *tsk, struct audit_context *ctx);
>  extern struct list_head *audit_killed_trees(void);
>  #else
>  #define audit_signal_info(s,t) AUDIT_DISABLED
> --
> 2.13.0
>



-- 
paul moore
www.paul-moore.com