linux-kernel - Re: [PATCH] cpufreq: conservative: Allow down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170612034035.GB5297@vireshk-i7>
Date:   Mon, 12 Jun 2017 09:10:35 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Tomasz Wilczyński <twilczynski@...er.com>
Cc:     rjw@...ysocki.net, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: conservative: Allow down_threshold to take
 values from 1 to 10

On 11-06-17, 17:28, Tomasz Wilczyński wrote:
> Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> Fix the logic in frequency decrease checking") removed the 10 point
> substraction when comparing the load against down_threshold but did not
> remove the related limit for the down_threshold value. As a result,
> down_threshold lower than 11 is not allowed even though values from
> 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> otherwise freq will not fall") is also not true after removing the
> substraction.
> 
> For this reason, allow down_threshold to take any value from 1 to 99
> and fix the related comment.
> 
> Signed-off-by: Tomasz Wilczyński <twilczynski@...er.com>

Please add Fixes tag and relevant kernel release for stable tag.

> ---
>  drivers/cpufreq/cpufreq_conservative.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> index 992f7c2..88220ff 100644
> --- a/drivers/cpufreq/cpufreq_conservative.c
> +++ b/drivers/cpufreq/cpufreq_conservative.c
> @@ -185,8 +185,8 @@ static ssize_t store_down_threshold(struct gov_attr_set *attr_set,
>  	int ret;
>  	ret = sscanf(buf, "%u", &input);
>  
> -	/* cannot be lower than 11 otherwise freq will not fall */
> -	if (ret != 1 || input < 11 || input > 100 ||
> +	/* cannot be lower than 1 otherwise freq will not fall */
> +	if (ret != 1 || input < 1 || input > 100 ||
>  			input >= dbs_data->up_threshold)
>  		return -EINVAL;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh