linux-kernel - Re: [PATCH] cpufreq: conservative: Allow down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3062414.lj8A9ADAOY@aspire.rjw.lan>
Date:   Mon, 12 Jun 2017 14:23:28 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Tomasz Wilczyński <twilczynski@...er.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10

On Monday, June 12, 2017 09:10:35 AM Viresh Kumar wrote:
> On 11-06-17, 17:28, Tomasz Wilczyński wrote:
> > Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> > Fix the logic in frequency decrease checking") removed the 10 point
> > substraction when comparing the load against down_threshold but did not
> > remove the related limit for the down_threshold value. As a result,
> > down_threshold lower than 11 is not allowed even though values from
> > 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> > otherwise freq will not fall") is also not true after removing the
> > substraction.
> > 
> > For this reason, allow down_threshold to take any value from 1 to 99
> > and fix the related comment.
> > 
> > Signed-off-by: Tomasz Wilczyński <twilczynski@...er.com>
> 
> Please add Fixes tag and relevant kernel release for stable tag.

Actually, the Fixes: tag would be sufficient and then adding it would be
appreciated.

No need to resend the patch, though.

Thanks,
Rafael