linux-kernel - Re: [PATCH v2 3/3] staging: rtl8188eu: Shorten lines over 80 chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497333816.18751.9.camel@perches.com>
Date:   Mon, 12 Jun 2017 23:03:36 -0700
From:   Joe Perches <joe@...ches.com>
To:     Aviya Erenfeld <aviyae42@...il.com>, gregkh@...uxfoundation.org,
        goudapatilk@...il.com, insafonov@...il.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8188eu: Shorten lines over 80 chars

On Tue, 2017-06-13 at 08:52 +0300, Aviya Erenfeld wrote:
> Shorten lines over 80 chars

Most of these changes are not useful.

Style nits if 80 columns are _really_ desired.

> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
[]
> @@ -157,7 +164,8 @@ u32	_rtw_free_sta_priv(struct	sta_priv *pstapriv)
>  				plist = plist->next;
>  
>  				for (i = 0; i < 16; i++) {
> -					preorder_ctrl = &psta->recvreorder_ctrl[i];
> +					preorder_ctrl =
> +						&psta->recvreorder_ctrl[i];
>  					del_timer_sync(&preorder_ctrl->reordering_ctrl_timer);

This is harder to read.

> @@ -453,14 +471,16 @@ u32 rtw_init_bcmc_stainfo(struct adapter *padapter)
>  {
>  	struct sta_info		*psta;
>  	u32 res = _SUCCESS;
> -	unsigned char bcast_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> +	unsigned char bcast_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff,
> +					      0xff};

More common would be

	unsigned char bcast_addr[ETH_ALEN] = {
		0xff, 0xff, 0xff, 0xff, 0xff, 0xff
	};

Better still would be to use static const.
Best would be to see if bcast_addr is needed at all.