linux-kernel - Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2017 11:22:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Aviya Erenfeld <aviyae42@...il.com>
Cc:     goudapatilk@...il.com, insafonov@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] staging: rtl8188eu: Remove redundant parenthesis

On Tue, Jun 13, 2017 at 08:50:38AM +0300, Aviya Erenfeld wrote:
> Remove redundant parenthesis
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index 2ecfb11..c6a7df5 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -91,7 +91,7 @@ u32	_rtw_init_sta_priv(struct	sta_priv *pstapriv)
>  	for (i = 0; i < NUM_STA; i++) {
>  		_rtw_init_stainfo(psta);
>  
> -		INIT_LIST_HEAD(&(pstapriv->sta_hash[i]));
> +		INIT_LIST_HEAD(&pstapriv->sta_hash[i]);

What complaines about these?  Does checkpatch?  Or something else?

It makes sense why they were added, don't you think so?  It makes the
code easier to understand in some places.

thanks,

greg k-h