linux-kernel - Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613080731.GB28618@localhost.localdomain>
Date:   Tue, 13 Jun 2017 09:07:31 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH] regulator: core: Prioritise consumer mappings over
 regulator name

On Mon, Jun 12, 2017 at 05:38:56PM +0100, Mark Brown wrote:
> On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:
> 
> >  	r = regulator_lookup_by_name(supply);
> > -	if (r)
> > -		return r;
> 
> Why have you left the lookup here?

Yeah was thinking that could maybe use a comment, if we don't
find a match in the following loop over the supply map then we
will exit with the regulator found here. So we can still use the
regulator name for lookup just we default to the supply map.

Thanks,
Charles