linux-kernel - Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to the common tps65217.dtsi file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqH_50syu5aHBQtJkh-Dpz8Yc_6w0X853DO46T3ZAAJ10F-Pw@mail.gmail.com>
Date:   Tue, 13 Jun 2017 11:08:39 +0200
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Javier Martinez Canillas <javier@...hile0.org>
Subject: Re: [PATCH 2/4] ARM: dts: tps65217: Add power button interrupt to the
 common tps65217.dtsi file

Hi Tony,

2017-06-13 9:35 GMT+02:00 Tony Lindgren <tony@...mide.com>:
> * Enric Balletbo i Serra <enric.balletbo@...labora.com> [170612 14:28]:
>> The interrupt for power button is static data that comes from the
>> datasheet, there is no reason to need to define this value on every
>> board so seams reasonable put this information into the common tps65217
>> file.
>
> I think there's a problem with these patches where we no longer know
> if the interrupts are wired up on a board. For example, if the USB PHY
> VBUS interrupt is not connected, the phy driver needs poll the
> cable state.
>

Hmm, the tps65217 doesn't have a USB PHY like others tps, so not sure
how could affect this patch. Did you see this issue in any board that
uses tps65217 or any am335x based board which commonly uses this pmic?

> And on some PMICs some pins can be muxed to GPIO mode, don't
> remember if that can be done with tps65217.
>

i don't think this is the case of the boards that use tps65217 as the
pins can't be muxed to GPIO mode.

> Regards,
>
> Tony

Regards,
 Enric