linux-kernel - Re: [PATCHv2 0/5] OMAP4: crypto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab778bfd-9397-4cb0-0741-557da57bba83@ti.com>
Date:   Tue, 13 Jun 2017 16:49:18 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Sebastian Reichel <sre@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Paul Walmsley <paul@...an.com>,
        Benoît Cousson <bcousson@...libre.com>
CC:     Russell King <linux@...linux.org.uk>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 0/5] OMAP4: crypto support

On 13/06/17 12:28, Sebastian Reichel wrote:
> Hi,
> 
> This adds crypto support for OMAP4, which was missing for some reason.
> This fixes error about missing hwmod on Droid 4. IP-Cores for AES and
> DES are working according to selftest.
> 
> Changes since PATCHv1:
>   * remove patch adding des_fck to DT
>   * add patch removing aes[12]_fck from DT
>   * add patch renaming hwmod aes to aes1 in DT
>   * update hwmod patches according to feedback from Tero
>   * add patch for aes2 hwmod
> 
> -- Sebastian

I just posted a few extra patches on top of this series, for adding the 
missing dts data for aes2 and adding sham accelerator also. The dts data 
should be applied first if you want to avoid any issues with hwmod core 
complaining about missing DT data, so the sequencing of this series and 
mine need to be done carefully.

The patches themselves in this series look fine now, so:

Acked-by: Tero Kristo <t-kristo@...com>

> 
> Sebastian Reichel (5):
>    ARM: dts: omap4: Fix aes entry
>    ARM: dts: omap4.dtsi: remove aes[12]_fck
>    ARM: OMAP4: hwmod data: add aes1
>    ARM: OMAP4: hwmod data: add aes2
>    ARM: OMAP4: hwmod data: add des
> 
>   arch/arm/boot/dts/omap4.dtsi               |   4 +-
>   arch/arm/boot/dts/omap44xx-clocks.dtsi     |  16 -----
>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 100 +++++++++++++++++++++++++++++
>   3 files changed, 102 insertions(+), 18 deletions(-)
>