linux-kernel - Re: [PATCHv2 0/5] OMAP4: crypto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613142458.32g3iqcijc4ij4b7@earth>
Date:   Tue, 13 Jun 2017 16:24:58 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Tero Kristo <t-kristo@...com>
Cc:     Tony Lindgren <tony@...mide.com>, Paul Walmsley <paul@...an.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Russell King <linux@...linux.org.uk>,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 0/5] OMAP4: crypto support

Hi,

On Tue, Jun 13, 2017 at 04:49:18PM +0300, Tero Kristo wrote:
> On 13/06/17 12:28, Sebastian Reichel wrote:
> > This adds crypto support for OMAP4, which was missing for some reason.
> > This fixes error about missing hwmod on Droid 4. IP-Cores for AES and
> > DES are working according to selftest.
> > 
> > Changes since PATCHv1:
> >   * remove patch adding des_fck to DT
> >   * add patch removing aes[12]_fck from DT
> >   * add patch renaming hwmod aes to aes1 in DT
> >   * update hwmod patches according to feedback from Tero
> >   * add patch for aes2 hwmod
> > 
> > -- Sebastian
> 
> I just posted a few extra patches on top of this series, for adding
> the missing dts data for aes2 and adding sham accelerator also.

Thanks :)

> The dts data should be applied first if you want to avoid any
> issues with hwmod core complaining about missing DT data, so the
> sequencing of this series and mine need to be done carefully.

There is also a warning printed if DT references a missing hwmod
entry (that's how I noticed this in the first place). It's less
noisy, though. Since kernel builds and boots with any order and
crypto hardware does not work at the moment there is no real
problem with bisect. I suggest to merge the DTS patches normally
through the separate dt branch.

> The patches themselves in this series look fine now, so:
> 
> Acked-by: Tero Kristo <t-kristo@...com>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)