linux-kernel - Re: [PATCH] tty: serial: lpuart: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613023818.GB15770@b29396-OptiPlex-7040>
Date:   Tue, 13 Jun 2017 10:38:18 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     Dong Aisheng <aisheng.dong@....com>, kbuild-all@...org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
        jslaby@...e.com, fugang.duan@....com, stefan@...er.ch,
        Mingkai.Hu@....com, yangbo.lu@....com,
        nikita.yoush@...entembedded.com, andy.shevchenko@...il.com,
        fengguang.wu@...el.com
Subject: Re: [PATCH] tty: serial: lpuart: fix semicolon.cocci warnings

Hi Fengguang,

On Tue, Jun 13, 2017 at 08:28:41AM +0800, kbuild test robot wrote:
> drivers/tty/serial/fsl_lpuart.c:305:2-3: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Dong Aisheng <aisheng.dong@....com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Seems not catched by checkpatch.

> ---
> 
>  fsl_lpuart.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -302,7 +302,7 @@ static inline void lpuart32_write(struct
>  	case UPIO_MEM32BE:
>  		iowrite32be(val, port->membase + off);
>  		break;
> -	};
> +	}

lpuart32_read needs the same fixing.

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index a66ed23..ed0bf18 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -288,7 +288,7 @@ static inline u32 lpuart32_read(struct uart_port *port, u32 off)
                return ioread32be(port->membase + off);
        default:
                return 0;
-       };
+       }
 }
 
 static inline void lpuart32_write(struct uart_port *port, u32 val,
@@ -301,7 +301,7 @@ static inline void lpuart32_write(struct uart_port *port, u32 val,
        case UPIO_MEM32BE:
                iowrite32be(val, port->membase + off);
                break;
-       };
+       }
 }

Thanks for the catching.

Regards
Dong Aisheng

>  }
>  
>  static void lpuart_stop_tx(struct uart_port *port)