linux-kernel - RE: [PATCH V3 5/7] tty: serial: lpuart: add imx7ulp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0401MB22607CE9EE3909A7A0B9451AFFC20@AM4PR0401MB2260.eurprd04.prod.outlook.com>
Date:   Tue, 13 Jun 2017 03:02:27 +0000
From:   Andy Duan <fugang.duan@....com>
To:     "A.s. Dong" <aisheng.dong@....com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jslaby@...e.com" <jslaby@...e.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        Mingkai Hu <mingkai.hu@....com>, "Y.b. Lu" <yangbo.lu@....com>,
        "nikita.yoush@...entembedded.com" <nikita.yoush@...entembedded.com>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        "dongas86@...il.com" <dongas86@...il.com>,
        "A.s. Dong" <aisheng.dong@....com>
Subject: RE: [PATCH V3 5/7] tty: serial: lpuart: add imx7ulp support

From: Dong Aisheng <aisheng.dong@....com> Sent: Monday, June 12, 2017 11:37 PM
>The lpuart of imx7ulp is basically the same as ls1021a. It's also
>32 bit width register, but unlike ls1021a, it's little endian.
>Besides that, imx7ulp lpuart has a minor different register layout from ls1021a
>that it has four extra registers (verid, param, global,
>pincfg) located at the beginning of register map, which are currently not used
>by the driver and less to be used later.
>
>To ease the register difference handling, we add a reg_off member in
>lpuart_soc_data structure to represent if the normal lpuart32_{read|write}
>requires plus a offset to hide the issue.
>
>Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>Cc: Jiri Slaby <jslaby@...e.com>
>Cc: Stefan Agner <stefan@...er.ch>
>Cc: Mingkai Hu <Mingkai.Hu@....com>
>Cc: Yangbo Lu <yangbo.lu@....com>
>Cc: Fugang Duan <fugang.duan@....com>
>Signed-off-by: Dong Aisheng <aisheng.dong@....com>
>
>---
>ChangeLog:
>v2->v3:
> * use standard port->iotype to represent the endians.
>v1->v2:
> * remove lpuart_reg_off according to Stefan's suggestion
>---
> drivers/tty/serial/fsl_lpuart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
>bbf47a0..9d05e53 100644
>--- a/drivers/tty/serial/fsl_lpuart.c
>+++ b/drivers/tty/serial/fsl_lpuart.c
>@@ -231,6 +231,9 @@
> #define DEV_NAME	"ttyLP"
> #define UART_NR		6
>
>+/* IMX lpuart has four extra unused regs located at the beginning */
>+#define IMX_REG_OFF	0x10
>+
> struct lpuart_port {
> 	struct uart_port	port;
> 	struct clk		*clk;
>@@ -259,6 +262,7 @@ struct lpuart_port {
>
> struct lpuart_soc_data {
> 	char	iotype;
>+	u8	reg_off;
> };
>
> static const struct lpuart_soc_data vf_data = { @@ -267,12 +271,17 @@ static
>const struct lpuart_soc_data vf_data = {
>
> static const struct lpuart_soc_data ls_data = {
> 	.iotype = UPIO_MEM32BE,
>+};
>
>+static struct lpuart_soc_data imx_data = {
>+	.iotype = UPIO_MEM32,
>+	.reg_off = IMX_REG_OFF,
> };
>
> static const struct of_device_id lpuart_dt_ids[] = {
> 	{ .compatible = "fsl,vf610-lpuart",	.data = &vf_data, },
> 	{ .compatible = "fsl,ls1021a-lpuart",	.data = &ls_data, },
>+	{ .compatible = "fsl,imx7ulp-lpuart",	.data = &imx_data, },
> 	{ /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, lpuart_dt_ids); @@ -2020,6 +2029,7 @@ static
>int lpuart_probe(struct platform_device *pdev)
> 	if (IS_ERR(sport->port.membase))
> 		return PTR_ERR(sport->port.membase);
>
>+	sport->port.membase += sdata->reg_off;
> 	sport->port.mapbase = res->start;

Also update the mapbase.

> 	sport->port.dev = &pdev->dev;
> 	sport->port.type = PORT_LPUART;
>--
>2.7.4