linux-kernel - Re: [PATCH v4 14/16] perf tool: add show_feature_header to perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170613185529.GG6092@krava>
Date:   Tue, 13 Jun 2017 20:55:29 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     David Carrillo-Cisneros <davidcc@...gle.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v4 14/16] perf tool: add show_feature_header to perf_tool

On Mon, Jun 12, 2017 at 09:29:30PM -0700, David Carrillo-Cisneros wrote:
> Add show_feat_hdr to control level of printed information
> of feature headers.
> 
> Signed-off-by: David Carrillo-Cisneros <davidcc@...gle.com>
> ---
>  tools/perf/builtin-report.c | 11 ++++++++---
>  tools/perf/builtin-script.c |  3 +++
>  tools/perf/util/tool.h      |  7 +++++++
>  3 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 22478ff2b706..7620d708c78b 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -985,9 +985,14 @@ int cmd_report(int argc, const char **argv)
>  		perf_hpp_list.need_collapse = true;
>  	}
>  
> -	/* Force tty output for header output and per-thread stat. */
> -	if (report.header || report.header_only || report.show_threads)
> -		use_browser = 0;
> +	if (report.header || report.header_only) {
> +		report.tool.show_feat_hdr = SHOW_FEAT_HEADER;
> +		/* Force tty output for header output and per-thread stat. */
> +		if (report.show_threads)
> +			use_browser = 0;
> +	}

this breaks show_threads option.. simple 'perf report -T' will not set use_browser

jirka