linux-kernel - Re: [PATCH v4 09/16] perf header: don't pass struct perf_file_section to process_##

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Jun 2017 18:51:48 -0700
From:   David Carrillo-Cisneros <davidcc@...gle.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v4 09/16] perf header: don't pass struct perf_file_section
 to process_##_feat

On Tue, Jun 13, 2017 at 11:54 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Mon, Jun 12, 2017 at 09:29:25PM -0700, David Carrillo-Cisneros wrote:
>
> SNIP
>
>>       struct cpu_cache_level *caches;
>>       u32 cnt, i, version;
>> @@ -2084,8 +2073,7 @@ static int process_cache(struct perf_file_section *section __maybe_unused,
>>  struct feature_ops {
>>       int (*write)(struct feat_fd *ff, struct perf_evlist *evlist);
>>       void (*print)(struct feat_fd *ff, FILE *fp);
>> -     int (*process)(struct perf_file_section *section,
>> -                    struct feat_fd *ff, void *data);
>> +     int (*process)(struct feat_fd *ff, void *data);
>>       const char *name;
>>       bool full_only;
>>  };
>> @@ -2616,9 +2604,11 @@ static int perf_file_section__process(struct perf_file_section *section,
>>                                     struct perf_header *ph,
>>                                     int feat, int fd, void *data)
>>  {
>> -     struct feat_fd ff = {
>> +     struct feat_fd fdd = {
>
> no need to rename to fdd
fixed
>
> jirka