linux-kernel - RE: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000101d2e4da$87e7e210$97b7a630$@socionext.com>
Date:   Wed, 14 Jun 2017 15:50:37 +0900
From:   "Keiji Hayashibara" <hayashibara.keiji@...ionext.com>
To:     Yamada, Masahiro/山田 真弘 
        <yamada.masahiro@...ionext.com>
Cc:     <wim@...ana.be>, "Guenter Roeck" <linux@...ck-us.net>,
        <linux-watchdog@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        "Masami Hiramatsu" <masami.hiramatsu@...aro.org>,
        "Jassi Brar" <jaswinder.singh@...aro.org>,
        Hayashi, Kunihiko/林 邦彦 
        <hayashi.kunihiko@...ionext.com>,
        Owada, Kiyoshi/大和田 清志 
        <owada.kiyoshi@...ionext.com>
Subject: RE: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver

Hello Yamada-san,

From: Masahiro Yamada [mailto:yamada.masahiro@...ionext.com]
Sent: Wednesday, June 14, 2017 12:08 PM
>
> 2017-06-13 10:14 GMT+09:00 Keiji Hayashibara
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 52a70ee..2a9d9a6 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -744,6 +744,17 @@ config ZX2967_WATCHDOG
> >           To compile this driver as a module, choose M here: the
> >           module will be called zx2967_wdt.
> >
> > +config UNIPHIER_WATCHDOG
> > +       tristate "UniPhier watchdog support"
> > +       depends on ARCH_UNIPHIER || COMPILE_TEST
> 
> This driver relies on syscon_node_to_regmap().
> Could you also add "depends on OF && MFD_SYSCON" ?

OK. I will fix this.
> 
> 
> > +       select WATCHDOG_CORE
> > +       help
> > +         Say Y here to include support watchdog timer embedded
> > +         into the UniPhier system.
> > +
> > +         To compile this driver as a module, choose M here: the
> > +         module will be called uniphier_wdt.
> > +

----------
Best Regards,
Keiji Hayashibara