linux-kernel - Re: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASq9MxUwDrNeRrg_eNkJbXR2J-9hHKGZe6-DtioO3p4cQ@mail.gmail.com>
Date:   Wed, 14 Jun 2017 12:07:31 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Keiji Hayashibara <hayashibara.keiji@...ionext.com>
Cc:     wim@...ana.be, Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Kiyoshi Owada <owada.kiyoshi@...ionext.com>
Subject: Re: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver

Hayashibara-san


2017-06-13 10:14 GMT+09:00 Keiji Hayashibara
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 52a70ee..2a9d9a6 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -744,6 +744,17 @@ config ZX2967_WATCHDOG
>           To compile this driver as a module, choose M here: the
>           module will be called zx2967_wdt.
>
> +config UNIPHIER_WATCHDOG
> +       tristate "UniPhier watchdog support"
> +       depends on ARCH_UNIPHIER || COMPILE_TEST

This driver relies on syscon_node_to_regmap().
Could you also add "depends on OF && MFD_SYSCON" ?




> +       select WATCHDOG_CORE
> +       help
> +         Say Y here to include support watchdog timer embedded
> +         into the UniPhier system.
> +
> +         To compile this driver as a module, choose M here: the
> +         module will be called uniphier_wdt.
> +



-- 
Best Regards
Masahiro Yamada