linux-kernel - Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATLopr81QFViOWPakYeR9udkj6FDEPDw3HtjyOWd1yM4w@mail.gmail.com>
Date:   Wed, 14 Jun 2017 16:40:37 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Matthias Kaehlcke <mka@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        "H . J . Lu" <hjl.tools@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Michal Marek <mmarek@...e.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michael Davidson <md@...gle.com>,
        Greg Hackmann <ghackmann@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Stephen Hines <srhines@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Bernhard Rosenkränzer 
        <Bernhard.Rosenkranzer@...aro.org>,
        Peter Foley <pefoley2@...oley.com>,
        Behan Webster <behanw@...verseincode.com>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

Hi Arnd,


2017-06-14 16:26 GMT+09:00 Arnd Bergmann <arnd@...db.de>:
> On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke <mka@...omium.org> wrote:
>> hostcc-option is equivalent to cc-option, but uses the host compiler
>> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
>> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>>
>> Suggested-by: Arnd Bergmann <arnd@...db.de>
>> Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
>
> Actually, we already have a hostcc-option macro. What I meant with my suggestion
> was that we could redefine the existing one using cc-option-raw.
>
> I checked again now and found that while this was added in 2016 by
> Emese Revfy, we apparently don't have any users of the helper in the
> kernel.


Oops, I missed it because
it is defined in scripts/Makefile.host instead of scripts/Kbuild.include


$(call cc-option, ...) is generally used in the top Makefile (or
arch/*/Makefile).


However, scripts/Makefile.host is not included from the top Makefile,
so $(call hostcc-option, ...) is available only under sub-directories.
I guess that is why we had no user of it.

I think the right thing to do
is to remove the former implementation from Makefile.host

Thanks!



-- 
Best Regards
Masahiro Yamada