linux-kernel - Re: [PATCH 1/3] printk/console: Remove superfluous setting of has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170614074104.GA3011@jagdpanzerIV.localdomain>
Date:   Wed, 14 Jun 2017 16:41:04 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Aleksey Makarov <aleksey.makarov@...aro.org>,
        Sabrina Dubroca <sd@...asysnail.net>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH 1/3] printk/console: Remove superfluous setting of
 has_preferred state value

On (06/13/17 14:54), Petr Mladek wrote:
> It is superfluous to set "has_preferred" when the really preferred
> console is enabled. The variable "i" is index of an array. Therefore
> "has_preferred" is set only when preferred_console is >= 0. But then
> it was already true because of the above code:
> 
> 	if (!has_preferred || bcon || !console_drivers)
> 		has_preferred = preferred_console >= 0;
> 
> This line was added by the commit ab4af03a4054bd78bc ("[PATCH] CON_CONSDEV
> bit not set correctly on last console"). It was kind of logic to store
> the really used index there. But this commit actually caused that
> "preferred_console" started to be used only as a boolean. This was
> discovered and corrected by the commit b077bafa2f3848ddfcef ("printk:
> fix name/type/scope of preferred_console var").
> 
> Signed-off-by: Petr Mladek <pmladek@...e.com>

agree.

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss

> ---
>  kernel/printk/printk.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index a1db38abac5b..8ebc480fdbc6 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2489,10 +2489,8 @@ void register_console(struct console *newcon)
>  		}
>  
>  		newcon->flags |= CON_ENABLED;
> -		if (i == preferred_console) {
> +		if (i == preferred_console)
>  			newcon->flags |= CON_CONSDEV;
> -			has_preferred = true;
> -		}
>  		break;
>  	}
>  
> -- 
> 1.8.5.6
>