linux-kernel - Re: [PATCH] i2c: tc358743: remove useless variable assignment in tc358743

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F23C0B09-8A98-4ADD-A584-28E156EE1E55@cisco.com>
Date:   Fri, 16 Jun 2017 07:28:20 +0000
From:   "Mats Randgaard (matrandg)" <matrandg@...co.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: tc358743: remove useless variable assignment in
 tc358743_isr

Thanks!
You could remove

intstatus &= ~MASK_HDMI_INT;

in line 1289 as well.

Regards,
Mats Randgaard

On 15/06/2017, 18:49, "Gustavo A. R. Silva" <garsilva@...eddedor.com> wrote:

    Remove useless variable assignment in function tc358743_isr().
    
    The value stored in variable _intstatus_ at line 1299 is
    overwritten at line 1302, just before it can be used.
    
    Addresses-Coverity-ID: 1397678
    Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
    ---
     drivers/media/i2c/tc358743.c | 1 -
     1 file changed, 1 deletion(-)
    
    diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
    index 3251cba..e8b23f3 100644
    --- a/drivers/media/i2c/tc358743.c
    +++ b/drivers/media/i2c/tc358743.c
    @@ -1296,7 +1296,6 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
     			tc358743_csi_err_int_handler(sd, handled);
     
     		i2c_wr16(sd, INTSTATUS, MASK_CSI_INT);
    -		intstatus &= ~MASK_CSI_INT;
     	}
     
     	intstatus = i2c_rd16(sd, INTSTATUS);
    -- 
    2.5.0