lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Jun 2017 10:43:28 +0200 From: Christoph Hellwig <hch@....de> To: Russell King - ARM Linux <linux@...linux.org.uk> Cc: Christoph Hellwig <hch@....de>, x86@...nel.org, linux-arm-kernel@...ts.infradead.org, xen-devel@...ts.xenproject.org, linux-c6x-dev@...ux-c6x.org, linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org, linux-mips@...ux-mips.org, openrisc@...ts.librecores.org, linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-xtensa@...ux-xtensa.org, dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-samsung-soc@...r.kernel.org, iommu@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 25/44] arm: implement ->mapping_error On Thu, Jun 08, 2017 at 03:43:14PM +0100, Russell King - ARM Linux wrote: > BOn Thu, Jun 08, 2017 at 03:25:50PM +0200, Christoph Hellwig wrote: > > +static int dmabounce_mapping_error(struct device *dev, dma_addr_t dma_addr) > > +{ > > + if (dev->archdata.dmabounce) > > + return 0; > > I'm not convinced that we need this check here: > > dev->archdata.dmabounce = device_info; > set_dma_ops(dev, &dmabounce_ops); > > There shouldn't be any chance of dev->archdata.dmabounce being NULL if > the dmabounce_ops has been set as the current device DMA ops. So I > think that test can be killed. Ok, I'll fix it up.
Powered by blists - more mailing lists