linux-kernel - Re: [PATCH v3 1/9] gpio: mvebu: fix regmap_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ2LuT50EMMOuT_FO0pz0nmO_fWhoBJd+Q76STWOpPNFA@mail.gmail.com>
Date:   Fri, 16 Jun 2017 11:18:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Nadav Haklai <nadavh@...vell.com>,
        Kostya Porotchkin <kostap@...vell.com>,
        Neta Zur Hershkovits <neta@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Omri Itach <omrii@...vell.com>,
        Shadi Ammouri <shadi@...vell.com>,
        Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        Ralph Sennhauser <ralph.sennhauser@...il.com>
Subject: Re: [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage

On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT
<gregory.clement@...e-electrons.com> wrote:

> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself but
> the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser@...il.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Tested-by: Ralph Sennhauser <ralph.sennhauser@...il.com>
> Tested-by: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
> Signed-off-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

Already applied this patch, sorry for missing the resend in the series.

Yours,
Linus Walleij