linux-kernel - Re: Applied "ASoC: rockchip: Fix an error handling in 'rockchip_i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170616091856.jz5d4trm5jz2ugan@sirena.org.uk>
Date:   Fri, 16 Jun 2017 10:18:56 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        heiko@...ech.de, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: Applied "ASoC: rockchip: Fix an error handling in
 'rockchip_i2s_probe'" to the asoc tree

On Fri, Jun 16, 2017 at 06:57:30AM +0200, Christophe JAILLET wrote:
> Le 15/06/2017 à 19:20, Mark Brown a écrit :

> >   	if (!of_property_read_u32(node, "rockchip,playback-channels", &val)) {
> >   		if (val >= 2 && val <= 8)
> >   			soc_dai->playback.channels_max = val;

> ... and 'err' should be 'ret'...

> I'm really confused for such a ugly proposal !

In a situation like this it's generally best to send a patch, I'll fix
though.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)