lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Jun 2017 11:25:37 +0530 From: Kishon Vijay Abraham I <kishon@...com> To: Tony Lindgren <tony@...mide.com> CC: <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org> Subject: Re: [PATCH] phy: cpcap-usb: Fix missing return statement On Monday 12 June 2017 01:42 PM, Tony Lindgren wrote: > Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > is missing return statement as noted by Colin Ian King > <colin.king@...onical.com>. If the optional pins are not configured, > we just want to return early and not attempt to configure the pins. > > Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > Reported-by: Colin Ian King <colin.king@...onical.com> > Signed-off-by: Tony Lindgren <tony@...mide.com> merged, thanks! -Kishon > --- > drivers/phy/motorola/phy-cpcap-usb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c > --- a/drivers/phy/motorola/phy-cpcap-usb.c > +++ b/drivers/phy/motorola/phy-cpcap-usb.c > @@ -468,6 +468,8 @@ static int cpcap_usb_init_optional_pins(struct cpcap_phy_ddata *ddata) > dev_info(ddata->dev, "default pins not configured: %ld\n", > PTR_ERR(ddata->pins)); > ddata->pins = NULL; > + > + return 0; > } > > ddata->pins_ulpi = pinctrl_lookup_state(ddata->pins, "ulpi"); >
Powered by blists - more mailing lists