linux-kernel - Re: [PATCH] bridge: Fix panel-bridge error return on !panel.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <836e590e-909a-3463-1d96-209040e1c317@codeaurora.org>
Date:   Fri, 16 Jun 2017 11:32:46 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Eric Anholt <eric@...olt.net>, dri-devel@...ts.freedesktop.org,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bridge: Fix panel-bridge error return on !panel.



On 06/15/2017 11:24 PM, Eric Anholt wrote:
> ERR_PTR() needs a negative errno argument.

Thanks, I'll queue it to drm-misc-next-fixes once it's opened.

Archit

> 
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
>   drivers/gpu/drm/bridge/panel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 99f9a4beb859..67fe19e5a9c6 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
>   	int ret;
>   
>   	if (!panel)
> -		return ERR_PTR(EINVAL);
> +		return ERR_PTR(-EINVAL);
>   
>   	panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
>   				    GFP_KERNEL);
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project