linux-kernel - Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem context [ver #5]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1bdc7bc-94f5-439f-915a-9dea06f646f2@infradead.org>
Date:   Sat, 17 Jun 2017 08:11:50 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jeff Layton <jlayton@...hat.com>,
        David Howells <dhowells@...hat.com>,
        Theodore Ts'o <tytso@....edu>
Cc:     Casey Schaufler <casey@...aufler-ca.com>, mszeredi@...hat.com,
        viro@...iv.linux.org.uk, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 08/27] VFS: Introduce the structs and doc for a filesystem
 context [ver #5]

On 06/17/2017 07:56 AM, Jeff Layton wrote:
> On Sat, 2017-06-17 at 15:18 +0100, David Howells wrote:
>> Theodore Ts'o <tytso@....edu> wrote:
>>
>>> I don't know that this is a hard and fast rule.  Struct bio uses a
>>> "bi_" prefix (e.g., bi_error, bi_opf, bi_iter, etc.).
>>
>> Linus told me to stop doing it.
>>
>> David
> 
> 
> That's a pity... I tend to like little prefixes on fields too. Trying to
> find all occurrences of a symbol called "flags" in cscope is a losing
> exercise.
> 
> Do you have a reference to the discussion so I can understand the
> rationale there?

Ack. This doesn't seem helpful.

He also objected to drivers with file names that begin with the parent
directory name, but we still have hundreds of those (see clk/, extcon/,
gpio/, hid/, i2c/, leds/ [then I stopped looking]).


-- 
~Randy