linux-kernel - Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170619193734.08f1697f@alans-desktop>
Date:   Mon, 19 Jun 2017 19:37:34 +0100
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Alexander Gerasiov <gq@...lab-i.ru>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single
 parallel port card.

On Sun, 18 Jun 2017 22:06:59 +0100
Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

> On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov wrote:
> > Hello Andy,
> > 
> > While preparing the update I suddenly found, that parport_serial.c is
> > not the right place for this card. Since there is no serial ports on
> > the board, it would be better to put it into parport_pc.c  
> 
> Yes, that will be better. Thanks.

Are the uarts physically present but the connector unwired, or are they
not detectable at all ?

If it's the former then can you add a comment in parport_serial.c giving
the ID and explaining why it's not present, even if you put the code into
parport_pc.

Alan