linux-kernel - Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170705140723.709d9c51@brick.gerasiov.net>
Date:   Wed, 5 Jul 2017 14:07:23 +0300
From:   Alexander Gerasiov <gq@...lab-i.ru>
To:     Alan Cox <gnomes@...rguk.ukuu.org.uk>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single
 parallel port card.

Hello Alan,

On Mon, 19 Jun 2017 19:37:34 +0100
Alan Cox <gnomes@...rguk.ukuu.org.uk> wrote:

> On Sun, 18 Jun 2017 22:06:59 +0100
> Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> 
> > On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov
> > wrote:  
> > > Hello Andy,
> > > 
> > > While preparing the update I suddenly found, that
> > > parport_serial.c is not the right place for this card. Since
> > > there is no serial ports on the board, it would be better to put
> > > it into parport_pc.c    
> > 
> > Yes, that will be better. Thanks.  
> 
> Are the uarts physically present but the connector unwired, or are
> they not detectable at all ?
> 
> If it's the former then can you add a comment in parport_serial.c
> giving the ID and explaining why it's not present, even if you put
> the code into parport_pc.

According to http://wiki.linuxcnc.org/cgi-bin/wiki.pl?WCH
the chip itself does not differ from one in card with dev-id 3253. So
technically one can solder connectors and use this card as 2serial +
1parallel.
But he could also remove link between pins 62 and 63 and get the board
indentified as 3252.

So, I believe, it would be less confusing (for users) if we do not
create serial devices for this adapter.


-- 
Best regards,
 Alexander Gerasiov

 Contacts:
 e-mail: gq@...msu.su  Homepage: http://gerasiov.net  Skype: gerasiov
 PGP fingerprint: 04B5 9D90 DF7C C2AB CD49  BAEA CA87 E9E8 2AAC 33F1