linux-kernel - RE: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <074e9d5668864a81b255df178ed28814@ausx13mpc120.AMER.DELL.COM>
Date:   Mon, 19 Jun 2017 16:13:13 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>, <luto@...nel.org>
CC:     <platform-driver-x86@...r.kernel.org>,
        <andriy.shevchenko@...ux.intel.com>, <luto@...capital.net>,
        <rjw@...ysocki.net>, <linux-kernel@...r.kernel.org>,
        <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded
 Binary WMI MOF metadata

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@...il.com]
> Sent: Monday, June 19, 2017 11:08 AM
> To: Andy Lutomirski <luto@...nel.org>
> Cc: platform-driver-x86@...r.kernel.org; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; Andy Lutomirski <luto@...capital.net>;
> Limonciello, Mario <Mario_Limonciello@...l.com>; Rafael Wysocki
> <rjw@...ysocki.net>; linux-kernel@...r.kernel.org; linux-acpi@...r.kernel.org
> Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded
> Binary WMI MOF metadata
> 
> On Tuesday 06 June 2017 05:16:44 Andy Lutomirski wrote:
> > Many laptops (and maybe servers?) have embedded WMI Binary MOF
> > metadata. We do not yet have open-source tools for processing the
> > data, although one is in the works thanks to Pali:
> >
> > 	https://github.com/pali/bmfdec
> >
> > There is currently no interface to get the data in the first place.
> > By exposing it, we facilitate the development of new tools.
> >
> > Signed-off-by: Andy Lutomirski <luto@...nel.org>
> > Cc: Andy Lutomirski <luto@...capital.net>
> > Cc: Mario Limonciello <mario_limonciello@...l.com>
> > Cc: Pali Rohár <pali.rohar@...il.com>
> > Cc: linux-kernel@...r.kernel.org
> > Cc: platform-driver-x86@...r.kernel.org
> > Cc: linux-acpi@...r.kernel.org
> > [dvhart: make sysfs mof binary read only, fixup comment block format]
> > [dvhart: use bmof terminology and dev_err instead of dev_warn]
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> > ---
> > since-v1:
> >  * address Pali's comments:
> >    * update the cover letter for clarity and accuracy
> >    * update mof->bmof and MOF to Binary MOF throughout the patch
> >    * use dev_err instead of dev_warn in wmi_bmof_probe
> >
> >
> >  drivers/platform/x86/Kconfig    |  12 ++++
> >  drivers/platform/x86/Makefile   |   1 +
> >  drivers/platform/x86/wmi-bmof.c | 125
> 
> Another suggestion (unrelated to this patch): For working with ACPI-WMI,
> this binary MOF buffer is not enough. It is needed also content of _WDG
> buffer. What about exporting it too via sysfs? Probably not part of of
> wmi-bmof driver, but wmi driver itself.
> 

I think this depends upon how the userspace access to WMI methods gets
implemented, no?  If userpsace access to WMI methods show up as
/dev/wmi-$GUID-$INSTANCE and those internally to the kernel map to
the proper ASL methods for example, what you get from wmi-bmof
should be enough shouldn't it?