linux-kernel - Re: [PATCH] tty: hide unused pty_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLr7t-CK4V7YhKnJSh-cwL0K3ME_oDReHCsCwX9mbs+MA@mail.gmail.com>
Date:   Tue, 20 Jun 2017 15:39:36 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Aleksa Sarai <asarai@...e.de>,
        Colin Ian King <colin.king@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: hide unused pty_get_peer function

On Tue, Jun 20, 2017 at 1:34 PM, Arnd Bergmann <arnd@...db.de> wrote:
> TIOCGPTPEER is only used for unix98 PTYs, and we get a warning
> when those are disabled:
>
> drivers/tty/pty.c:466:12: error: 'pty_get_peer' defined but not used [-Werror=unused-function]
>
> This moves the respective functions inside of the existing #ifdef.
>
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Pixel Security