linux-kernel - Re: [PATCH] tty: hide unused pty_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b39fdd1f-8e85-0e0d-3564-d6e76241b0da@suse.de>
Date:   Wed, 21 Jun 2017 09:10:37 +1000
From:   Aleksa Sarai <asarai@...e.de>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Colin Ian King <colin.king@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: hide unused pty_get_peer function

> TIOCGPTPEER is only used for unix98 PTYs, and we get a warning
> when those are disabled:
> 
> drivers/tty/pty.c:466:12: error: 'pty_get_peer' defined but not used [-Werror=unused-function]
> 
> This moves the respective functions inside of the existing #ifdef.
> 
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Oops, I missed that.

   Acked-by: Aleksa Sarai <asarai@...e.de>

-- 
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/