linux-kernel - Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170620064539.GA12930@Red>
Date:   Tue, 20 Jun 2017 08:45:39 +0200
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Jessica Yu <jeyu@...hat.com>
Cc:     rusty@...tcorp.com.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and
 del_usage_link functions

On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
> +++ Corentin Labbe [06/06/17 14:17 +0200]:
> >This patch just swap del_usage_link() before add_usage_link().
> >
> >Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> 
> Could you combine this with the 2nd patch? By itself this patch
> doesn't tell us much. Additionally, could you explain in the changelog
> (of the 2nd patch) why they needed to be swapped (i.e., so
> del_usage_links() can be called from add_usage_links()).
> 
> Thanks!
> 
> Jessica
> 

I think that its against the rule of atomic/simple patch.
Perhaps, the first patch miss some "why I do it"

Anyway I will send a new version as you requested
Regards