linux-kernel - Re: [PATCH V2 2/2] hwmon: (ibmpowernv) Add current(A) sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2e849bf-01a0-9af6-cb14-0c454a902d23@kaod.org>
Date:   Tue, 20 Jun 2017 08:05:01 +0200
From:   Cédric Le Goater <clg@...d.org>
To:     Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>,
        linux@...ck-us.net, stewart@...ux.vnet.ibm.com
Cc:     jdelvare@...e.com, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, svaidy@...ux.vnet.ibm.com,
        ego@...ux.vnet.ibm.com, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH V2 2/2] hwmon: (ibmpowernv) Add current(A) sensor

On 06/20/2017 07:08 AM, Shilpasri G Bhat wrote:
> This patch exports current(A) sensors in inband sensors copied to
> main memory by OCC.
> 
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@...ux.vnet.ibm.com>

Reviewed-by: Cédric Le Goater <clg@...d.org>

Thanks,

C.

> ---
> Changes from V1:
> - Rebased on top of Cedric's patch to remove legay-compatible type for
>   the current(A) sensor.
> 
>  drivers/hwmon/ibmpowernv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 6d8909c..9b11b13 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -50,6 +50,7 @@ enum sensors {
>  	TEMP,
>  	POWER_SUPPLY,
>  	POWER_INPUT,
> +	CURRENT,
>  	MAX_SENSOR_TYPE,
>  };
>  
> @@ -75,7 +76,8 @@ enum sensors {
>  	{ "fan"   },
>  	{ "temp"  },
>  	{ "in"    },
> -	{ "power" }
> +	{ "power" },
> +	{ "curr"  },
>  };
>  
>  struct sensor_data {
>