linux-kernel - Re: [PATCH] drm: sti: sti_hqvdp: make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks7fCYRhvjaiJzOggsVL-B4vRFb7ef_jr4LFiEGXQOBwig@mail.gmail.com>
Date:   Tue, 20 Jun 2017 13:28:21 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: sti: sti_hqvdp: make of_device_ids const.

2017-06-20 7:05 GMT+02:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
>    text    data     bss     dec     hex filename
>   15845     640       0   16485    4065 drivers/gpu/drm/sti/sti_hqvdp.o
>
> File size after constify hqvdp_of_match:
>    text    data     bss     dec     hex filename
>   16229     224       0   16453    4045 drivers/gpu/drm/sti/sti_hqvdp.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied on drm-misc-next, thanks

> ---
>  drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 267d816..075802d 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1396,7 +1396,7 @@ static int sti_hqvdp_remove(struct platform_device *pdev)
>         return 0;
>  }
>
> -static struct of_device_id hqvdp_of_match[] = {
> +static const struct of_device_id hqvdp_of_match[] = {
>         { .compatible = "st,stih407-hqvdp", },
>         { /* end node */ }
>  };
> --
> 1.9.1
>