linux-kernel - Re: [PATCH] drm: sti: sti_hqvdp: Fix compilation warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+M3ks6NvoDsqtnaJc3bDqQU3y8qP2No5P727GfgO-aqrWgNxg@mail.gmail.com>
Date:   Tue, 20 Jun 2017 13:29:15 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: sti: sti_hqvdp: Fix compilation warning.

2017-06-20 6:55 GMT+02:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
> Replace '%d' by '%zu' and '%lu' to fix the following compilation warning:-
>
> drivers/gpu/drm/sti/sti_hqvdp.c: In function ‘sti_hqvdp_start_xp70’:
> drivers/gpu/drm/sti/sti_hqvdp.c:925:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
>    DRM_ERROR("Invalid firmware size (%d)\n", firmware->size);
>    ^
> drivers/gpu/drm/sti/sti_hqvdp.c:930:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
>    DRM_ERROR("Invalid fmw structure (%d+%d+%d+%d+%d != %d)\n",
>    ^
> drivers/gpu/drm/sti/sti_hqvdp.c:930:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 9 has type ‘size_t’ [-Wformat=]

I do not manage to reproduce the warnings on my side so I will merge
this patch yet.

Regards
Benjamin

>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 66f8431..267d816 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -922,12 +922,12 @@ static void sti_hqvdp_start_xp70(struct sti_hqvdp *hqvdp)
>
>         header = (struct fw_header *)firmware->data;
>         if (firmware->size < sizeof(*header)) {
> -               DRM_ERROR("Invalid firmware size (%d)\n", firmware->size);
> +               DRM_ERROR("Invalid firmware size (%zu)\n", firmware->size);
>                 goto out;
>         }
>         if ((sizeof(*header) + header->rd_size + header->wr_size +
>                 header->pmem_size + header->dmem_size) != firmware->size) {
> -               DRM_ERROR("Invalid fmw structure (%d+%d+%d+%d+%d != %d)\n",
> +               DRM_ERROR("Invalid fmw structure (%lu+%d+%d+%d+%d != %zu)\n",
>                           sizeof(*header), header->rd_size, header->wr_size,
>                           header->pmem_size, header->dmem_size,
>                           firmware->size);
> --
> 1.9.1
>