linux-kernel - Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170620164851.GA32699@pali>
Date:   Tue, 20 Jun 2017 18:48:58 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     "Lee, Chun-Yi" <joeyli.kernel@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Lee, Chun-Yi" <jlee@...e.com>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote:
> Pali Rohár found that there have some wmi query/evaluation
> code that they used 'one' as the first WMI instance number.
> But the number is indexed from zero that it's must less than
> the instance_count in _WDG.
> 
> This patch changes those instance number from one to zero.
> 
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andy Shevchenko <andy@...radead.org>
> Cc: Pali Rohár <pali.rohar@...il.com> 
> Signed-off-by: "Lee, Chun-Yi" <jlee@...e.com>

Looks good, Reviewed-by: Pali Rohár <pali.rohar@...il.com>

> ---
>  drivers/platform/x86/acer-wmi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 79fa5ab..ef420b6 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -700,7 +700,7 @@ struct acpi_buffer *result)
>  	input.length = sizeof(struct wmab_args);
>  	input.pointer = (u8 *)regbuf;
>  
> -	status = wmi_evaluate_method(AMW0_GUID1, 1, 1, &input, result);
> +	status = wmi_evaluate_method(AMW0_GUID1, 0, 1, &input, result);
>  
>  	return status;
>  }
> @@ -965,7 +965,7 @@ WMI_execute_u32(u32 method_id, u32 in, u32 *out)
>  	u32 tmp = 0;
>  	acpi_status status;
>  
> -	status = wmi_evaluate_method(WMID_GUID1, 1, method_id, &input, &result);
> +	status = wmi_evaluate_method(WMID_GUID1, 0, method_id, &input, &result);
>  
>  	if (ACPI_FAILURE(status))
>  		return status;
> @@ -1275,7 +1275,7 @@ static acpi_status __init WMID_set_capabilities(void)
>  	acpi_status status;
>  	u32 devices;
>  
> -	status = wmi_query_block(WMID_GUID2, 1, &out);
> +	status = wmi_query_block(WMID_GUID2, 0, &out);
>  	if (ACPI_FAILURE(status))
>  		return status;
>  
> @@ -2018,7 +2018,7 @@ static u32 get_wmid_devices(void)
>  	acpi_status status;
>  	u32 devices = 0;
>  
> -	status = wmi_query_block(WMID_GUID2, 1, &out);
> +	status = wmi_query_block(WMID_GUID2, 0, &out);
>  	if (ACPI_FAILURE(status))
>  		return 0;
>  

-- 
Pali Rohár
pali.rohar@...il.com