linux-kernel - Re: [PATCH] net: intel: e1000e: add check on e1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 14:52:08 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Ethan Zhao <ethan.kernel@...il.com>
Cc:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        intel-wired-lan@...ts.osuosl.org, netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return
 value

Hi Ethan,

Quoting Ethan Zhao <ethan.kernel@...il.com>:

> Gustavo,
>
>    The return value of ret_val seems used to check if the access to PHY/NVM
> got its semaphore,  generally speaking, it is needed for every PHY
> access of this driver.
>
> Reviewed-by: Ethan Zhao <ethan.zhao@...cle.com>
>

Thank you very much for the clarification.

> On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva
> <garsilva@...eddedor.com> wrote:
>> Check return value from call to e1e_wphy(). This value is being
>> checked during previous calls to function e1e_wphy() and it seems
>> a check was missing here.
>>
>> Addresses-Coverity-ID: 1226905
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c  
>> b/drivers/net/ethernet/intel/e1000e/ich8lan.c
>> index 68ea8b4..d6d4ed7 100644
>> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
>> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
>> @@ -2437,6 +2437,8 @@ static s32  
>> e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
>>                 if (hw->phy.revision < 2) {
>>                         e1000e_phy_sw_reset(hw);
>>                         ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
>> +                       if (ret_val)
>> +                               return ret_val;
>>                 }
>>         }
>>
>> --
>> 2.5.0
>>

--
Gustavo A. R. Silva