linux-kernel - Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that can migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622092934.jokgiprvf5m7krdi@gmail.com>
Date:   Thu, 22 Jun 2017 11:29:34 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Daniel Bristot de Oliveira <bristot@...hat.com>
Cc:     linux-rt-users <linux-rt-users@...r.kernel.org>,
        "Luis Claudio R . Goncalves" <lgoncalv@...hat.com>,
        Clark Williams <williams@...hat.com>,
        Luiz Capitulino <lcapitulino@...hat.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] sched/debug: Inform the number of rt/dl task that
 can migrate


* Daniel Bristot de Oliveira <bristot@...hat.com> wrote:

> Add the value of the rt_rq.rt_nr_migratory and dl_rq.dl_nr_migratory
> to the sched_debug output, for instance:
> 
> rt_rq[0]:
>   .rt_nr_running                 : 2
>   .rt_nr_migratory               : 1     <--- Like this
>   .rt_throttled                  : 0
>   .rt_time                       : 828.645877
>   .rt_runtime                    : 1000.000000
> 
> This is useful to debug problems related to the dl/rt schedulers.
> 
> This also fixes the format of some variables, that were unsigned, rather
> than signed.
> 
> [ I am sending this patch to be able to demonstrate       ]
> [ the problem in the kernel-rt, however, this patch can   ]
> [ be merged in the vanilla kernel, if people decide it    ]
> [ is worth having it.                                     ]

Note that this patch breaks in various cross-builds - here's the Alpha defconfig 
build:

/home/mingo/tip/kernel/sched/debug.c: In function 'print_rt_rq':
/home/mingo/tip/kernel/sched/debug.c:556:60: error: 'struct rt_rq' has no member 
named 'rt_nr_migratory'
  SEQ_printf(m, "  .%-30s: %lu\n", #x, (unsigned long)(rt_rq->x))
                                                            ^
/home/mingo/tip/kernel/sched/debug.c:33:17: note: in definition of macro 
'SEQ_printf'
   seq_printf(m, x);  \
...

Thanks,

	Ingo