linux-kernel - Re: [PATCH RESEND 08/13] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622194605.GC85041@decatoncale.mtv.corp.google.com>
Date:   Thu, 22 Jun 2017 12:46:05 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     olof@...om.net, bleung@...omium.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, Archana Patni <archana.patni@...el.com>,
        Thierry Escande <thierry.escande@...labora.com>,
        bleung@...gle.com
Subject: Re: [PATCH RESEND 08/13] platform/chrome: cros_ec_lpc: Add power
 management ops

Hi Enric and Thierry,

On Tue, May 16, 2017 at 06:13:14PM +0200, Enric Balletbo i Serra wrote:
> From: Archana Patni <archana.patni@...el.com>
> 
> This patch adds suspend and resume pm ops to the LPC ChromeOS EC driver.
> These LPC handlers call the croc_ec generic handlers.
> 
> Signed-off-by: Archana Patni <archana.patni@...el.com>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>

Signed-off-by: Benson Leung <bleung@...omium.org>

Applied. Thanks.

> ---
>  drivers/platform/chrome/cros_ec_lpc.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 90703521..89afad7 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -333,10 +333,31 @@ static struct dmi_system_id cros_ec_lpc_dmi_table[] __initdata = {
>  };
>  MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table);
>  
> +#ifdef CONFIG_PM_SLEEP
> +static int cros_ec_lpc_suspend(struct device *dev)
> +{
> +	struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
> +
> +	return cros_ec_suspend(ec_dev);
> +}
> +
> +static int cros_ec_lpc_resume(struct device *dev)
> +{
> +	struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
> +
> +	return cros_ec_resume(ec_dev);
> +}
> +#endif
> +
> +const struct dev_pm_ops cros_ec_lpc_pm_ops = {
> +	SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume)
> +};
> +
>  static struct platform_driver cros_ec_lpc_driver = {
>  	.driver = {
>  		.name = DRV_NAME,
>  		.acpi_match_table = cros_ec_lpc_acpi_device_ids,
> +		.pm = &cros_ec_lpc_pm_ops,
>  	},
>  	.probe = cros_ec_lpc_probe,
>  	.remove = cros_ec_lpc_remove,
> -- 
> 2.9.3
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)