linux-kernel - Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170623211757.GA145579@google.com>
Date:   Fri, 23 Jun 2017 14:17:58 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Nick Vaccaro <nvaccaro@...gle.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

(Kernel mailing lists don't usually like HTML mail. Gmail web interface
can get plain text if you really try, in one of the 'compose' options.
But it'll always screw up patch formatting, so it's only worth light
use)

On Fri, Jun 23, 2017 at 02:04:44PM -0700, Nick Vaccaro wrote:
>    Hi Brian,
>    Thanks for the info, I'm new to this process.

No problem, and understood.

>    I was asked to create a FIXUP CL and send it upstream.  Not knowing
>    format of a "FIXUP" cl, I looked at other FIXUP cl's in the chromeos
>    kernel and followed suit.

There are various reasons we might use a "FIXUP" prefix within the
Chrome OS kernel; among them: a patch might diverge upstream, as it gets
reviewed, but we might already have applied the patch to our tree.

In this case, you have a totally new patch.

[If you wanted to represent the "FIXUP" concept here, you might use a
tag like this, before the Signed-off-by:

Fixes: 1f0d3bb02785 ("pwm: Add ChromeOS EC PWM driver")
]

If in doubt, check the git log for examples (as you did already), but
note that there are different practices for mainline Linux and for the
Chromium OS, as Chromium OS is a downstream project.

>    I emailed it upstream with a "FIXUP: CHROMIUM:" prefix. Should I change
>    the checkin comment title line to "[PATCH] pwm: cros-ec: fix transposed
>    param settings" and resend the email?

Yes, that'd be all.

(And you can include my 'Reviewed-by:' tag when you resend.)

>    Please advise, thanks.

Brian